Skip to content

Conversation

@germanosin
Copy link
Member

  • Breaking change? (if so, please describe the impact and migration path for existing application instances)

What changes did you make? (Give an overview)

Is there anything you'd like reviewers to focus on?

How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)

  • No need to
  • Manually (please, describe, if necessary)
  • Unit checks
  • Integration checks
  • Covered by existing automation

Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (e.g. ENVIRONMENT VARIABLES)
  • My changes generate no new warnings (e.g. Sonar is happy)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged

Check out Contributing and Code of Conduct

A picture of a cute animal (not mandatory but encouraged)

@germanosin germanosin requested a review from a team as a code owner November 5, 2025 21:53
@kapybro kapybro bot added status/triage Issues pending maintainers triage status/triage/completed Automatic triage completed and removed status/triage Issues pending maintainers triage labels Nov 5, 2025
@Haarolean Haarolean added type/enhancement En enhancement/improvement to an already existing feature scope/backend Related to backend changes labels Nov 6, 2025
@germanosin germanosin requested a review from Copilot November 6, 2025 15:12
@germanosin germanosin merged commit 365b9fe into main Nov 6, 2025
26 checks passed
@germanosin germanosin deleted the consumer_groups_search_apply_fts branch November 6, 2025 15:14
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds support for the fts (Full-Text Search) parameter to the consumer groups pagination endpoint, allowing clients to control whether full-text search functionality is used when filtering consumer groups.

  • Added fts Boolean parameter to getConsumerGroupsPage methods in both controller and service layers
  • Updated filterGroups method to accept and use the FTS parameter via ftsProperties.use(useFts)
  • Renamed variable fts to ftsProperties for clarity when introducing the boolean FTS flag

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
ConsumerGroupService.java Added fts parameter to getConsumerGroupsPage method and updated filterGroups to accept and process the FTS parameter
ConsumerGroupsController.java Added fts parameter to controller method and passed it to the service layer

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

scope/backend Related to backend changes status/triage/completed Automatic triage completed type/enhancement En enhancement/improvement to an already existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants